-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9.0 [mig] marketing_security_group #128
9.0 [mig] marketing_security_group #128
Conversation
Hi @cubells , It doesn't work. For example, demo user cannot delete it's own mass mailings. Check image: Please review Thanks! |
The branch is not correct. You have to check again your git-fu. |
@rafaelbn Now user can delete his own mass_mailing campaigns if belongs to Lead Automation user group, not to marketing group. And it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming module marketing_security_group to mass_mailing_security_group
If you rename an addon, you need to write a migration script.
These 2 commits have the same message:
We need to have descriptive messages for commits, to know what you are doing in each of them and why. It only takes some seconds and you help all of us.
Your branch has conflicts:
Please do a rebase or merge and fix them.
Thanks 😉
There's no need for a migration script, but a rename in the apriori.py file in OpenUpgrade, but he knows that and will make the PR when this one is merged. |
@cubells please check this. |
a56b5ca
to
ba3d3b6
Compare
ba3d3b6
to
a359ec5
Compare
done. |
* Renaming module marketing_security_group to mass_mailing_security_group * Changes in README * Correct views
e1b6aeb
to
648e7b2
Compare
He's on holidays and his concerns have been attended
Module renamed in OpenUpgrade in OCA/OpenUpgrade@544f656 |
Renaming module marketing_security_group to mass_mailing_security_group
cc @Tecnativa